injector: push apart overlapping traps #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@drakvuf-jenkins Test this please |
|
@tklengyel can you please restart the infer job, as it's fail is not related to the changes of this PR |
alex-pentagrid
force-pushed
the
injector-trap-overlap-fix
branch
from
5ad7e84 to
000a22f
Compare
|
@drakvuf-jenkins Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changed vdso layout in modern kernels (at least 6.2), linux injector when parsing vdso in
find_syscallcan first find the address of the trap we are already standing on. This leads to a violation of the injection logic.So in this case we can simply skip first occurence of
syscallcall in vdso and try to find next.