Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note severity #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Note severity #13

wants to merge 2 commits into from

Conversation

canadaduane
Copy link

Fixes #7

);
break;
default:
if (showGutterIcon) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right behavior. I can see two possibilities:

  • the showGutterIcon setting should be absolute & final, i.e. NO gutter icons whatsoever
  • OR the showGutterIcon should be for default icons. If the user adds severity hashtags in the note, the presence of the tag overrides the showGutterIcon setting.

I've implemented the latter.

@canadaduane
Copy link
Author

There is currently a bug in this PR that makes all notes the color of the highest severity note :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: note importance
1 participant