Skip to content

Commit

Permalink
feat: update deps (#60)
Browse files Browse the repository at this point in the history
Signed-off-by: tkrop <[email protected]>
  • Loading branch information
tkrop committed Dec 15, 2023
1 parent 1324cef commit 3f3c666
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ issues:
linters: [ errcheck ]
# Exclude certain revive standards from being applied in tests.
- path: "_test\\.go"
text: "^(max-public-structs|function-length|cognitive-complexity|unchecked-type-assertion):"
text: "^(max-public-structs|function-length|cognitive-complexity):"
linters: [ revive ]
# Exclude dots in unfinished thoughts.
- source: "(noinspection|TODO)"
Expand Down Expand Up @@ -160,6 +160,9 @@ linters-settings:
# Fails to disable writers that actually cannot return errors.
- name: unhandled-error
disabled: true
# Fails to detect and exclude type safe usages of type assertions.
- name: unchecked-type-assertion
disabled: true
# Fails to restrict sufficiently in switches with numeric values.
- name: add-constant
disabled: true
Expand Down
24 changes: 24 additions & 0 deletions Makefile.defs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Setup environment for all run-targets (to be modified)
define run-setup
true
endef

# Define variables for all run-targets (to be modified)
define run-vars

endef

# Define variables for local run-targets (to be modified)
define run-vars-local

endef

# Define variables for image run-targets (to be modified)
define run-vars-image

endef

# Define aws localstack setup (to be modified).
define run-aws-setup
true
endef
1 change: 0 additions & 1 deletion internal/mock/models.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ func NewMethods(iface *types.Interface) []*Method {
methods := make([]*Method, 0, iface.NumMethods())
for index := 0; index < iface.NumMethods(); index++ {
method := iface.Method(index)
//revive:disable-next-line:unchecked-type-assertion // cannot happen
sign := method.Type().Underlying().(*types.Signature)
methods = append(methods, &Method{
Name: method.Name(),
Expand Down
1 change: 0 additions & 1 deletion mock/mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ func (mocks *Mocks) notify(
// Get resolves the actual mock from the mock handler by providing the
// constructor function generated by `gomock` to create a new mock.
func Get[T any](mocks *Mocks, creator func(*Controller) *T) *T {
//revive:disable-next-line:unchecked-type-assertion // cannot happen
return mocks.Get(reflect.ValueOf(creator)).(*T)
}

Expand Down

0 comments on commit 3f3c666

Please sign in to comment.