feat: improve test runner and accessor (#91) #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the test runner adding a new feature for filtering test cases using regular expressions and improves the builder/accessor providing more tests (including bug fixes) and an additional feature for finding typed and named fields in structures. Unfortunately, it still fails for simple structs wrapped in interfaces and thereby cannot replace a specialized version used for parameter structs yet.
However, the tests around the accessor pattern made a mock generator issue obvious. Currently, the mock generator cannot provide mocks for incomplete loaded and broken packages because of the early failure handing it implements. It currently looks, as if the early failure handling could be simply dropped. Only four test would need adjustment mapping the failures differently.