-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#468 #484 #470 LTI Integration #494
#468 #484 #470 LTI Integration #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me, and locally runs as expected. Google analytics is also behaving normally, the only thing missing relating to the OneTrust integration is the redirect from /privacy to the privacy link in the environment variables. I could add this in a separate issue if you'd like to move forward with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Just create that issue @jaydonkrooss mentioned if you didn't already.
@jaydonkrooss I have created the issue since felt it will be easier to do without a re-review. This issue can be worked anytime after this PR get merged. |
Fixes #468 #484 #470
This PR handles the complete LTI integration for CCM, also enabling backend debugging.
createsuperuser
django command and login tohttp://0.0.0.0/admin/
with login with credential created then add the LTI Registration.3. Also You can look at my LTI configuration from Canvas Test and start from there.
4. DeploymentID is needed. So just follow along the instructions
context_processors.py
as script tag, currently the globals are fetched using API call.6.
useGlobals.ts
hook will go away, the callsgetGlobals
andgetCSRF
is not needed. but I am going to keep that until API integration component via DRF added. But I added logic in such a way that I am injecting global fromcontext_processors.py
to useGlobals as intermediate step.7. The Globals will reflect LTI launch user. So login with different users and see the results
hasCanvasToken
it is hard-coded since that variable is related to Canvas OAuth integration. So Please be aware for the value hasCanvasToken=true incontext_processors.py
Next Steps: