Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages*: update links to https and remove www #13650

Conversation

sebastiaanspeck
Copy link
Member

@sebastiaanspeck sebastiaanspeck commented Sep 9, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

#13633; I have checked the URLs using #12506 and checked the differences with the results from the main-branch by hand.

@github-actions github-actions bot added documentation Issues/PRs modifying the documentation. page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages. labels Sep 9, 2024
@sebastiaanspeck sebastiaanspeck force-pushed the update-links-to-https-and-remove-www branch from a8b63b6 to 9e18cd4 Compare September 9, 2024 19:38
@sebastiaanspeck sebastiaanspeck force-pushed the update-links-to-https-and-remove-www branch from 9e18cd4 to 6b4e96d Compare September 9, 2024 19:41
@sebastiaanspeck

This comment was marked as resolved.

@sebastiaanspeck sebastiaanspeck marked this pull request as draft September 9, 2024 19:47
@sebastiaanspeck sebastiaanspeck added the mass changes Changes that affect multiple pages. label Sep 9, 2024
@tldr-bot

This comment was marked as duplicate.

@tldr-bot

This comment was marked as duplicate.

@tldr-bot

This comment has been minimized.

@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review September 24, 2024 20:20
@sebastiaanspeck sebastiaanspeck marked this pull request as draft September 24, 2024 20:20
@sbrl
Copy link
Member

sbrl commented Sep 29, 2024

This looks good to me, except www. appears to have been removed automatically. Have the new links there been double checked? It would likely be fine to do it on a per-domain basis. If you've got a list of all URLs somewhere, then in theory you could spit out a list of the most popular domains to double check?

That and the branch will need updating, but I suspect you'll do that last.

@sebastiaanspeck
Copy link
Member Author

Thank you for your review. In tldr-maintenance, we use lychee now, I will double-check the removal of www, but I can also split up this PR into two; one PR for switching to https and one PR for removing www.

@sebastiaanspeck sebastiaanspeck self-assigned this Sep 30, 2024
@sbrl
Copy link
Member

sbrl commented Oct 1, 2024

Sounds like a good plan! That will make it simpler to merge.

@sebastiaanspeck
Copy link
Member Author

Sounds like a good plan! That will make it simpler to merge.

Started in #13907, but I will work on it in the near future. Not all pages can simply be converted to https.

@sebastiaanspeck
Copy link
Member Author

Closed this since we will split the work in smaller PRs. Keeping the branch for a little longer for historical reasons.

@sebastiaanspeck
Copy link
Member Author

#13907 is created to address the switch to https

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation. mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants