Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for arbitrary bit depths (<= 32) #143

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

chrstphrbrns
Copy link
Contributor

Fixes #58

To test various bit depths, this command will be useful:

% convert image.tif -depth N [-colorspace gray] [-interlace plane] [-compress zip/lzw/rle/none] out.tif

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (79d5508) 92.76% compared to head (bc0a4d2) 92.89%.

Files Patch % Lines
src/ifds.jl 95.68% 5 Missing ⚠️
src/layout.jl 86.84% 5 Missing ⚠️
src/compression.jl 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   92.76%   92.89%   +0.12%     
==========================================
  Files          13       13              
  Lines         982     1069      +87     
==========================================
+ Hits          911      993      +82     
- Misses         71       76       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlnagy tlnagy self-requested a review January 4, 2024 23:48
Copy link
Owner

@tlnagy tlnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, some minor points

src/ifds.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
@tlnagy tlnagy merged commit 1f19bab into tlnagy:master Jan 7, 2024
11 of 13 checks passed
@chrstphrbrns chrstphrbrns deleted the chris/12 branch March 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12-bit tiff support
3 participants