Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for lazy-loading tiled images #165

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

chrstphrbrns
Copy link
Contributor

Fixes #164

Copy link
Owner

@tlnagy tlnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chris, thanks for tackling #164, but I'm not sure if this is the best approach. The Matrix(transform(...) call is a major allocation on access. Why is this necessary to fix lazy loading tiles?

src/types/lazy.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (1eec9cf) to head (49019ad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   93.67%   92.68%   -0.99%     
==========================================
  Files          13       13              
  Lines        1122     1121       -1     
==========================================
- Hits         1051     1039      -12     
- Misses         71       82      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlnagy tlnagy merged commit 25cf338 into tlnagy:master Oct 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazyio does not load tiled TIFFs correctly
3 participants