-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gear: userspace permissions interface (types + pokes) #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copied lib and types from @urbit/api repo to gear/ - migrated webterm types (see: urbit/webterm#3) - rename S3 --> Storage
also uninstall @urbit/api
- remove @urbit/api - remove @urbit/http-api - remove urbit-ob - add @urbit/aura - add urbit/js-http-api (via github repo) - remove all references to @urbit/api - replace with references to @/gear for most types, @urbit/aura for helpers, and js-http-api for network types (via the github repo; replace with npm package when published)
tomholford
commented
May 26, 2023
tomholford
commented
May 26, 2023
tomholford
commented
May 26, 2023
@tinnus-napbus or @Fang- : could use your feedback on the inline comments at your convenience |
- Treaty now supports Seal
LAND-514 migrate tloncorp/landscape references types and api pokes
|
Based on out of band conversation with ~tinnus-napbus, some changes are necessary for this interface. Closing in favor of #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is part of an ongoing effort to implement Userspace Permissions UI (#182).
The Typescript types are derived from
lull.hoon
in this PR:https://github.com/urbit/urbit/pull/6493/files#diff-01fd10efd392903ad3f191b1caddb67dba7d57d11997894173665d20f0d42477
and
lib/perms.hoon
from here:https://github.com/tloncorp/landscape/pull/164/files#diff-418361e9c7bf8b945e9e34d68b4a363ba4ea46e2c400be84df6bdab9d15664e2
The updates for Permissions are in two separate repos:
urbit/urbit
andtloncorp/landscape
:passport
lives inurbit/urbit
due to it's usage in the upcoming|okay
perms mgmt cli tooltloncorp/landscape
This resolves #177
Changes
Fixes LAND-514