ops: true 411 kelvin compat #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to want to pull in the new /lib/strandio, which we need to be able to build. The signature for %keen changed, so the old /lib/strandio no longer compiles. If we had a custom version of /lib/strandio that excluded the +keen arms, we could be 412-411 cross-compatible...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation:
/lib/strandio, from which its threads use a couple of arms.%keentask./lib/strandiocontains helpers for building%keentasks. So, it changes across the kelvin version in a non-compatible way./lib/strandio.The minimal fix is the combination of this PR, and a (likely manual) ops step where we pull in the zuse 411 version of
/lib/strandiofrom the urbit/urbit repo's/pkg/base-dev.A more involved but lower-user-impact fix would be to signal compatibility with both 412 and 411, and update the
/lib/strandioon the landscape desk to exclude the+keenarms the "official" version includes. Landscape desk doesn't use them itself.Update: urbit/urbit now has a
tlon/strandio-412-411from which that file can be pulled.cc @arthyn @mrozanski for ops advice, cc @pkova for having called discovered this.