reel: migrate old tokens and update link flow to match #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
approved these changes
Sep 16, 2024
| ?: =('' url) | ||
| ~[[%give %fact ~[[%token-link (scot %p src.bowl) token ~]] %json !>(~)]] | ||
| ~[[%give %fact ~[[%token-link (scot %p src.bowl) token ~]] %json !>(s+url)]] | ||
| =/ path (stab (cat 3 '/token-link/' token)) |
There was a problem hiding this comment.
Some smell on this not being /token-link/(scot %t token), but iirc that's for backcompat reasons that are out of scope here, right?
There was a problem hiding this comment.
(Also some of the cords in the surrounding code should probably be token:reels.)
There was a problem hiding this comment.
hmm this should be able to work I think
Comment on lines
+87
to
+95
| |= [[=token:reel =metadata:reel] [md=_our-metadata id=_stable-id]] | ||
| ?^ (slaw %uv token) [md id] | ||
| ?^ (rush token flag) | ||
| :- md | ||
| ?: (~(has by id) token) id | ||
| (~(put by id) token token) | ||
| =/ new (rap 3 (scot %p our.bowl) '/' token ~) | ||
| :- (~(put by md) new metadata) | ||
| (~(put by id) new new) |
There was a problem hiding this comment.
This is fine to run on every load, because none of the transformations result in follow-up:
- New-style tokens (
@uvformat) are untouched, - "New old-style" tokens (
~ship/termformat) only guarantee they have an entry instable-id, - "Old old-style" tokens get upgraded into "new old-style" tokens and put an entry in
stable-id.
Correct?
There was a problem hiding this comment.
(I'd still feel more comfortable with migration moving into state version %5, fwiw, just because it doesn't even risk repeated transforms.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT, we only migrated tokens in %bait, but we need to migrate them here in %reel so that both the old UI and the new UI can work.