-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native: on-network and lure invites #3867
Conversation
FYI, I didn't use zustand persist w/AsyncStorage because of this issue: https://stackoverflow.com/questions/78262236/import-meta-is-currently-unsupported-in-eas-build We're already on 3.7.2, so I'm not sure why that worked for them. It looks like we need to update to the latest zustand, and I thought that might open up a can of worms with our other uses of zustand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked on device! Can send invites and generate lure links
I'm noticing that same issue you mentioned on the context fix where certain option actions are shown inconsistently, but I think we can handle that in a followup.
Fixes TLON-2526, using mostly the same zustand store for lure we used on web, requires tloncorp/landscape#277 to go in as well if we want it to be a bit quicker (not having to wait on a timeout for the
token-link/${flag}
subscribeOnce call).Also fixes:
client
rather thanclientInstance
(this was causing thetrue
to appear to return for thetoken-link
subscribeOnce call, it was actually the response from thegroup-enabled
subscribeOnce)Note: this automatically enables lure invites any time you attempt to invite someone to a group. We need a way for admins to override this somewhere else in the app (cc: @jamesacklin)
Also note that this can't be tested on android at the moment because no chat list options work on Android in develop for some reason.