Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: on-network and lure invites #3867

Merged
merged 11 commits into from
Aug 30, 2024
Merged

Conversation

patosullivan
Copy link
Member

@patosullivan patosullivan commented Aug 28, 2024

Fixes TLON-2526, using mostly the same zustand store for lure we used on web, requires tloncorp/landscape#277 to go in as well if we want it to be a bit quicker (not having to wait on a timeout for the token-link/${flag} subscribeOnce call).

Also fixes:

  • an issue where our our subscribeOnce in the api/urbit module was attempting to use subscribeOnce on client rather than clientInstance (this was causing the true to appear to return for the token-link subscribeOnce call, it was actually the response from the group-enabled subscribeOnce)
  • an issue where we weren't passing contacts into the AppDataContext for the AddGroupSheet, so you couldn't actually search by contact to find a group.
  • lack of verbosity on logging from the urbit api module (we turn on verbose if we're in dev mode now, will only be seen if you turn on the logger in the urbit module).

Note: this automatically enables lure invites any time you attempt to invite someone to a group. We need a way for admins to override this somewhere else in the app (cc: @jamesacklin)

Also note that this can't be tested on android at the moment because no chat list options work on Android in develop for some reason.

Copy link

linear bot commented Aug 28, 2024

@patosullivan patosullivan changed the title wip: on-network and lure invites on mobile native: on-network and lure invites Aug 29, 2024
@patosullivan patosullivan marked this pull request as ready for review August 29, 2024 21:07
@patosullivan
Copy link
Member Author

FYI, I didn't use zustand persist w/AsyncStorage because of this issue: https://stackoverflow.com/questions/78262236/import-meta-is-currently-unsupported-in-eas-build

We're already on 3.7.2, so I'm not sure why that worked for them. It looks like we need to update to the latest zustand, and I thought that might open up a can of worms with our other uses of zustand.

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on device! Can send invites and generate lure links

I'm noticing that same issue you mentioned on the context fix where certain option actions are shown inconsistently, but I think we can handle that in a followup.

@patosullivan patosullivan merged commit 0744094 into develop Aug 30, 2024
1 check passed
@patosullivan patosullivan deleted the po/tlon-2526-group-invites branch August 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants