lure: individualized links #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add changes to mobile as well |
patosullivan
approved these changes
Sep 10, 2024
Fang-
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Some comments. Primarily, you can't save yourself from scry crashes by virtualizing.
428f4e6 is a weird inclusion for this particular pr, and on its face I don't immediately like it because it (lightly) obscures the extent to which chat and channel structures are identical. I don't feel super strongly though.
Fang-
reviewed
Sep 10, 2024
| @@ -138,7 +138,7 @@ | |||
| =/ wir=^wire /dm/(scot %p joiner.bite) | |||
| =/ =dock [our.bowl %chat] | |||
| =/ =id:c [our now]:bowl | |||
| =/ =memo:c | |||
| =/ =memo:ch | |||
There was a problem hiding this comment.
fwiw, you could've done memo:d:c here.
Co-authored-by: fang <[email protected]>
Fang-
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates lure from the %groups perspective, changing %grouper and the web frontend to work with the new %reel flow. Fixes TLON-2517
PR Checklist