Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%contacts activity #4175

Merged
merged 3 commits into from
Nov 20, 2024
Merged

%contacts activity #4175

merged 3 commits into from
Nov 20, 2024

Conversation

mikolajpp
Copy link
Collaborator

Implements activity source and events for contact book updates.
Fixes TLON-3176.

Copy link

linear bot commented Nov 13, 2024

@mikolajpp mikolajpp changed the base branch from develop to lb/contacts-ui November 13, 2024 08:21
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this was ready yet, but @latter-bolden was asking for a review. cool to see how little you had to change the agent, LGTM!

desk/app/activity.hoon Outdated Show resolved Hide resolved
@mikolajpp
Copy link
Collaborator Author

Note that this must go in together with tloncorp/landscape#297

Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! Almost good, thanks.

desk/app/channels.hoon Show resolved Hide resolved
@mikolajpp mikolajpp marked this pull request as ready for review November 20, 2024 15:03
@mikolajpp mikolajpp merged commit 41b2250 into lb/contacts-ui Nov 20, 2024
1 check passed
@mikolajpp mikolajpp deleted the mp/contacts-activity branch November 20, 2024 15:03
@mikolajpp mikolajpp restored the mp/contacts-activity branch November 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants