Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channels: add missing scry and update usage in activity #4185

Merged
merged 1 commit into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions desk/app/activity.hoon
Original file line number Diff line number Diff line change
Expand Up @@ -1180,8 +1180,7 @@
=. importing &
=. indices (~(put by indices) [%base ~] *index:a)
=. cor set-chat-reads
::REVIEW maybe need a scry api version bump here?
=+ .^(=channels:c %gx (scry-path %channels /v2/channels/full/noun))
=+ .^(=channels:c %gx (scry-path %channels /v3/channels/full/noun))
=. cor (set-volumes channels)
=. cor (set-channel-reads channels)
=. cor refresh-all-summaries
Expand Down
3 changes: 3 additions & 0 deletions desk/app/channels.hoon
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,9 @@
::
[%x %v2 %channels full=?(~ [%full ~])]
``channels-2+!>((uv-channels-2:utils v-channels ?=(^ full.pole)))
::
[%x %v3 %channels full=?(~ [%full ~])]
``channels-3+!>((uv-channels-3:utils v-channels ?=(^ full.pole)))
::
[%x ?(%v0 %v1) %init ~] ``noun+!>([unreads (uv-channels-1:utils v-channels)])
[%x %v2 %init ~] ``noun+!>([unreads (uv-channels-2:utils v-channels |)])
Expand Down
2 changes: 1 addition & 1 deletion desk/mar/channels-2.hoon
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
--
++ grab
|%
++ noun channels:d
++ noun channels:v1:old:d
--
--
14 changes: 14 additions & 0 deletions desk/mar/channels-3.hoon
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/- c=channels
/+ j=channel-json
|_ =channels:c
++ grad %noun
++ grow
|%
++ noun channels
++ json (channels-2:enjs:j channels)
--
++ grab
|%
++ noun channels:c
--
--