-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop: fixes omnibus #4215
desktop: fixes omnibus #4215
Conversation
…e-web to 0.18, add some width to the sidebar, fix style issues with the close button on the TextInputWithIconButton, fixes TLON-3251
Awesome, thanks. I'll pull this down and take a look today. |
The downgrade to react-native-web 18 is causing an issue with updating the scroller when sending a message, looking into it. |
…from an ESM module, fixes animations errors and allows use of the ChatListSearch on web
Ok, we didn't need to downgrade to rnw 18, we just needed to patch a file in reanimated. See updated description. |
…ve 'button' group from Button component, adjust margin a bit on TextInputWithIconAndButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Fixes TLON-3248 by including the EditProfile screen in the ProfileScreenNavigatorStack.
Fixes TLON-3249 by removing the camera option and adjusting the copy on web for the attachment sheet/modal.
Fixes TLON-3250 by removing an unnecessary flex style on ListItemEndContent
Fixes TLON-3251 by downgrading react-native-web to 0.18.12 (latest 0.18), which fixes an issue with react-native-reanimated where it can't animate at least some components (see this issue: software-mansion/react-native-reanimated#4335, the fix is included in our version of react-native-reanimated, but the issue still occurs for us unless we downgrade to 0.18).Fixes TLON-3251 by patching react-native-reanimated. A distributed JS module (
react-native-reanimated/lib/module/reanimated2/js-reanimated/index.js
) included some require statements, this causedcreateReactDOMStyle
to be undefined when it shouldn't have been, which meant that we didn't fall into the correct branch of_updatePropsJS
in that file, and jumped to the next conditional where we checked for a property that can't exist on a dom node on web, which threw the "Cannot convert undefined or null to object" error we were seeing. This was preventing some (maybe all?) animations that included updates to a style prop from working, such as ChatListSearch.