Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: fixes omnibus #4215

Merged
merged 6 commits into from
Nov 25, 2024
Merged

desktop: fixes omnibus #4215

merged 6 commits into from
Nov 25, 2024

Conversation

patosullivan
Copy link
Member

@patosullivan patosullivan commented Nov 21, 2024

Fixes TLON-3248 by including the EditProfile screen in the ProfileScreenNavigatorStack.

Fixes TLON-3249 by removing the camera option and adjusting the copy on web for the attachment sheet/modal.

Fixes TLON-3250 by removing an unnecessary flex style on ListItemEndContent

Fixes TLON-3251 by downgrading react-native-web to 0.18.12 (latest 0.18), which fixes an issue with react-native-reanimated where it can't animate at least some components (see this issue: software-mansion/react-native-reanimated#4335, the fix is included in our version of react-native-reanimated, but the issue still occurs for us unless we downgrade to 0.18).

Fixes TLON-3251 by patching react-native-reanimated. A distributed JS module (react-native-reanimated/lib/module/reanimated2/js-reanimated/index.js) included some require statements, this caused createReactDOMStyle to be undefined when it shouldn't have been, which meant that we didn't fall into the correct branch of _updatePropsJS in that file, and jumped to the next conditional where we checked for a property that can't exist on a dom node on web, which threw the "Cannot convert undefined or null to object" error we were seeing. This was preventing some (maybe all?) animations that included updates to a style prop from working, such as ChatListSearch.

@jamesacklin
Copy link
Member

Awesome, thanks. I'll pull this down and take a look today.

@patosullivan patosullivan marked this pull request as draft November 21, 2024 21:42
@patosullivan
Copy link
Member Author

The downgrade to react-native-web 18 is causing an issue with updating the scroller when sending a message, looking into it.

…from an ESM module, fixes animations errors and allows use of the ChatListSearch on web
@patosullivan patosullivan marked this pull request as ready for review November 22, 2024 17:36
@patosullivan
Copy link
Member Author

Ok, we didn't need to downgrade to rnw 18, we just needed to patch a file in reanimated. See updated description.

…ve 'button' group from Button component, adjust margin a bit on TextInputWithIconAndButton
Copy link
Contributor

@dnbrwstr dnbrwstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@patosullivan patosullivan merged commit 91f6eb3 into develop Nov 25, 2024
1 check passed
@patosullivan patosullivan deleted the po/desktop-fixes-omnibus branch November 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants