desktop: fix big input, and other desktop web issues #4238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes TLON-3273 (making the BigInput actually usable on desktop) We weren't accounting for big input height.
Also fixes other issues:
Notebooks weren't wrapped in a Pressable.
Some bad conditional checks were causing text strings to render outside of Text components/directly within Stack components.
Edits weren't working at all for notebook posts (we weren't filling in the draft content, we weren't passing along the title, and we weren't handling situations where the post had an image).
We were still unnecessarily using a ScrollView for the web version of the BigInput.
We had no way to allow the user to exit the big input editor if they wanted to abandon creating a post.
We were attempting to pass
contentFit
as a prop toimg
tags for web, which isn't a valid attribute, which made the image header in the notebook editor too large. I added a way to catchcontentFit
and pass it to theimg
as anobjectFit
property in the style prop. This also fixes an issue where image avatars weren't displaying correctly much of the time.We had no overflow menu button on notebook posts, so there was no way to get to the message options on desktop.
General cleanup of the web MessageInput component.
Edit: now also adds an overflow button for gallery posts.