contacts: fix events showing up in the feed #4243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
channels: custom hooks
…ght-weirdness desktop: fix ChatList/ChannelList height/space weirdness
* refactor chat query * cleanup
…84-contacts-screen-profile-screen-theme-fixes desktop: fix routing/crash issues in settings, add contacts, add themes
contacts: quick fixes
native: + button on contacts screen for quick/bulk adding
hooks: allow no-op'ing if none
… height to 100% rather than auto
…able Pressable while we're hovering over the overflow button
…-other-web-issues desktop: fix big input, and other desktop web issues
ProfileStatusSheet: add send button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT
Fixes TLON-3345 by always permitting contact update events to be included while bundling (irrespective of notify status).
Also updates the logic to include contact events in separate "activity bundles". Since we don't roll them up on the client, we need to treat them as distinct sources to avoid misrepresenting the timeline (similar to how we treat mentions).