native: fix contact activity showing up in feed #4244
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolajpp
reviewed
Dec 4, 2024
| @@ -590,7 +590,7 @@ | |||
| :: we only care about posts/replies events that are notified, and we | |||
| :: don't want to include events from sources whose latest event is | |||
| :: after the start so we always get "new" sources when paging | |||
| ?. ?& notified.event | |||
| ?. ?& ?|(notified.event ?=(%contact -<.event)) | |||
There was a problem hiding this comment.
Seems like this circumvents the intended logic, but @arthyn approved this for now.
There was a problem hiding this comment.
yeah I think this is an ok compromise for now. what we really want are volume settings related to "where" an activity item should show up like unreads, feed, push notifications, etc. we had talked about it when first building activity, but it had already gone long so we decided to go with what we have.
mikolajpp
requested changes
Dec 4, 2024
Co-authored-by: Mikolaj <[email protected]>
|
Last commit fixed it, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT
Fixes TLON-3345 by always permitting contact update events to be included while bundling (irrespective of notify status).
Also updates the logic to include contact events in separate "activity bundles". Since we don't roll them up on the client, we need to treat them as distinct sources to avoid misrepresenting the timeline (similar to how we treat mentions).