Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some quality of life improvements #124

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

mve
Copy link
Contributor

@mve mve commented Oct 2, 2023

  • Replaced bluebird promise with regular Node.js Promise
  • Removed deasync, i believe that package is no longer used?
    This also removes a dependency on Python.
  • Updated README.md
  • Fixed error in console about i18n "wait"
    https://stackoverflow.com/a/75727176/8678755
  • Added steps to check webpack bundle size

Checking the bundle size i noticed that in src/i18n.js, the add-all-tz import adds about 1MB. to the JS, can this be improved?

- Replaced bluebird promise with regular Node.js Promise
- Removed deasync, i believe that package is no longer used?
- Updated README.md
- Fixed error in console about i18n "wait"
- Added steps to check webpack bundle size
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #124 (4814c2a) into master (b0d1c12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          59       59           
  Lines         955      955           
  Branches      207      207           
=======================================
  Hits          922      922           
  Misses         31       31           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tmoitie
Copy link
Owner

tmoitie commented Oct 5, 2023

Thanks for all this!

Checking the bundle size i noticed that in src/i18n.js, the add-all-tz import adds about 1MB. to the JS, can this be improved?

I remember this when I added it that there wasn't much choice, but now I see we could potentially use @formatjs/intl-datetimeformat/add-golden-tz . The risk here is just that it might degrade the experience for users who don't have a "golden" timezone preference, and I don't have the data to figure out the likelyhood of that.

@tmoitie tmoitie merged commit d354f97 into tmoitie:master Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants