Merge pull request #254 from tnc-ca-geo/fix/253-comments_popover

Fix scroll ref issue when deleting all comments, #253
tnc-ca-geo · Nov 4, 2024 · 56d9f8f · 56d9f8f
2 parents cc7895a + da6252e
commit 56d9f8f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/features/loupe/CommentsPopover.jsx b/src/features/loupe/CommentsPopover.jsx
@@ -114,24 +114,24 @@ export const CommentsPopover = ({ onClose, comments, imageId, onChangeActionMenu
   const [isShiftDown, setIsShiftDown] = useState(false);
   const handleKeyDown = (event) => {
     event.stopPropagation();
-    if (event.key === "Shift") {
+    if (event.key === 'Shift') {
       setIsShiftDown(true);
     }
-    if (event.key === "Enter" && !isShiftDown) {
+    if (event.key === 'Enter' && !isShiftDown) {
       handleAddComment(addCommentText);
       event.preventDefault();
     }
-  }
+  };
   const handleKeyUp = (event) => {
-    if (event.key === "Shift") {
+    if (event.key === 'Shift') {
       setIsShiftDown(false);
     }
-  }
+  };
   // Scroll to bottom when adding a new comment
   const scrollRef = useRef();
   useEffect(() => {
-    if (scrollRef.current !== undefined) {
-      scrollRef.current.scrollIntoView({ behavior: "smooth" });
+    if (scrollRef.current) {
+      scrollRef.current.scrollIntoView({ behavior: 'smooth' });
     }
   }, [comments]);