misc clean up and comments

tnc-ca-geo · Feb 1, 2022 · df2894e · df2894e
1 parent ae7cb6e
commit df2894e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/src/features/images/ImagesPanel.js b/src/features/images/ImagesPanel.js
@@ -5,7 +5,6 @@ import { styled } from '../../theme/stitches.config.js';
 import { selectWorkingImages } from '../review/reviewSlice';
 import {
   fetchImages,
-  selectImages,
   selectHasNext,
   selectIsLoading,
   selectPaginatedField,

diff --git a/src/features/images/imagesSlice.js b/src/features/images/imagesSlice.js
@@ -9,7 +9,7 @@ import { IMAGE_QUERY_LIMITS } from '../../config';
 import { DATE_FORMAT_EXIF as EXIF } from '../../config';
 
 const initialState = {
-  images: [],
+  images: [], // we are barely using this... consider removing?
   isLoading: false,
   isUpdatingObjects: false,
   isEditingLabel: false,
@@ -80,6 +80,7 @@ export const imagesSlice = createSlice({
       state.visibleRows = payload;
     },
 
+    // NOTE: not using updateObject anymore
     updateObjectsStart: (state) => { state.isUpdatingObjects = true; },
 
     updateObjectsFailure: (state, { payload }) => {

diff --git a/src/features/loupe/BoundingBox.js b/src/features/loupe/BoundingBox.js
@@ -207,7 +207,10 @@ const BoundingBox = ({
         onMouseEnter={handleBBoxHover}
         onMouseLeave={handleBBoxMouseLeave}
         selected={objectFocused}
-        css={{ borderColor: labelColor.primary }}
+        css={{ 
+          borderColor: labelColor.primary,
+          background: labelColor.primary + '0D',
+        }}
       >
         {label &&
           <BoundingBoxLabel

diff --git a/src/features/loupe/LoupeFooter.js b/src/features/loupe/LoupeFooter.js
@@ -8,17 +8,12 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import IconButton from '../../components/IconButton';
 import { selectUserUsername } from '../user/userSlice';
 import { selectImagesCount } from '../images/imagesSlice';
+import { selectIsAddingLabel, selectReviewMode } from './loupeSlice';
 import {
-  labelValidated,
   incrementFocusIndex,
   incrementImage,
   selectFocusIndex,
 } from '../review/reviewSlice';
-import {
-  selectIsAddingLabel,
-  selectReviewMode 
-} from './loupeSlice';
-import { validateSDL } from 'graphql/validation/validate';
 
 const IndexDisplay = styled('div', {
   fontFamily: '$mono',

diff --git a/src/features/review/reviewSlice.js b/src/features/review/reviewSlice.js
@@ -117,6 +117,9 @@ export const reviewSlice = createSlice({
         state.workingImages = [];
       })
       .addCase(updateObjectsSuccess, (state, { payload }) => {
+        // TODO: we don't use updateObject anymore, so this isn't doing anything
+        // consider pushing returned images from editLabelSuccess into
+        // working images instead? 
         const imgId = payload.updateObjects.image._id;
         const newObjects = payload.updateObjects.image.objects;
         const image = state.workingImages.find(img => img._id === imgId);