Adding Bulk Image Deletion Option #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jue-henry
commented
Nov 1, 2024
nathanielrindlaub
requested changes
Nov 4, 2024
There was a problem hiding this comment.
@jue-henry this is looking solid. I was doing this review on the plane and didn't have sufficient internet to test the new features, however, but from what I can tell it looks like it should work as intended.
I think there are some opportunities to simplify some things, so take a look at the comments and let me know if it's easier to discuss on the phone or to keep the convo going here in Github.
jue-henry
commented
Nov 5, 2024
jue-henry
commented
Nov 7, 2024
jue-henry
commented
Nov 12, 2024
nathanielrindlaub
approved these changes
Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.