289/267: fix comments popover bug and improve ux #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: when removing all content from comment, show delete comment ux
This was referenced Jan 10, 2025
nathanielrindlaub
approved these changes
Jan 11, 2025
nathanielrindlaub
deleted the
fix/289-267-comments-improvements-and-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes: tnc-ca-geo/animl-api#289, #261
Adds: #267
Fixes a bug which caused errors when editing comments to include no content. Instead, show the delete comment ui/ux similar to Slack.
Fixes bug which caused comments popover to stay open when changing images with keyboard.
Adds the 'confirm edit on enter' functionality that the new comments ui/ux has. New lines can be added with shift + enter.
Commits