Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

165: Filtering by tags #284

Merged
merged 6 commits into from
Jan 23, 2025
Merged

165: Filtering by tags #284

merged 6 commits into from
Jan 23, 2025

Conversation

nathanielrindlaub
Copy link
Member

@nathanielrindlaub nathanielrindlaub commented Jan 20, 2025 •
edited
Loading

Closes #165, #168

Related PR

animl-api

@nathanielrindlaub
Copy link
Member Author

nathanielrindlaub commented Jan 23, 2025 •
edited
Loading

New filter checklist:

animl-api

  • Update MongoDB schema (FiltersSchema)
  • Update GraphQL Type Defs (type-defs/objects/Filters.js, type-defs/inputs/QueryImagesInput.js)
  • run npm run codegen to generate types

animl-frontend

  • Update buildQuery.js viewFields to include new filter
  • update filterSlice.js
  • update projectsMiddleware.js diffFiltersMiddleware() function that diffs filters from current view & current active filters (if needed)
  • Make sure new filter is explicitly set when fetching Image context (fetchImageContext())

@nathanielrindlaub nathanielrindlaub merged commit 7d49770 into main Jan 23, 2025
2 checks passed
@nathanielrindlaub nathanielrindlaub deleted the feature/165-filter-by-tags branch January 23, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter by Tags
1 participant
@nathanielrindlaub