Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Split algorithm added #136
Merge Split algorithm added #136
Changes from 1 commit
b156b45
b550e3b
edc5f25
d1f23b4
d3aa8ea
cbc80f8
d94e390
6ba5d41
1c3c04b
9d05857
a25f984
c25f588
6327c8d
99cb179
6391513
b9c4d26
c6c8766
fb18413
2a9255c
17339eb
53cf5b3
f23b6b3
dd88c30
51d87b9
971b0cb
9c0e33e
7e62652
a40b27d
fa09e96
8412ba4
5354ebe
9e722f8
019d0f3
ef48aa9
4b11015
d85e19c
800fdfe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible that these would be better off in a JSON. That would allow us to pull from there to build the documentation, too. However, I don't think that's necessary for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might look into scikit-learn's distancematrixes: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.pairwise_distances.html . I think that will do this, but much faster. Not strictly necessary, but something to investigate if it's a quick drop-in replacement.
Also, same comment as above on comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so this wasn't a small change, but I changed this component of the merge_split algorithm to implement matrices. It's significantly faster currently.