Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.5.0 notebooks #308

Merged
merged 3 commits into from
Jul 12, 2023
Merged

V1.5.0 notebooks #308

merged 3 commits into from
Jul 12, 2023

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Jul 11, 2023 •
edited
Loading

Add new script to run notebooks, based off of @lettlini s actions
Re-generate notebooks for v1.5.0 release

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones requested a review from freemansw1 July 11, 2023 00:13
@w-k-jones w-k-jones self-assigned this Jul 11, 2023
@w-k-jones w-k-jones added this to the Version 1.5 milestone Jul 11, 2023
@w-k-jones w-k-jones mentioned this pull request Jul 11, 2023
Closed
9 tasks
freemansw1
freemansw1 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my one comment. I'm not interested in holding up v1.5.0 for it, so I'm happy to merge now.

@freemansw1 freemansw1 added the release Organising the next release on conda-forge label Jul 11, 2023
@freemansw1 freemansw1 requested a review from JuliaKukulies July 11, 2023 22:12
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (891c8e8) 56.04% compared to head (3373585) 56.04%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           RC_v1.5.0     #308   +/-   ##
==========================================
  Coverage      56.04%   56.04%           
==========================================
  Files             15       15           
  Lines           3290     3290           
==========================================
  Hits            1844     1844           
  Misses          1446     1446
Flag Coverage Δ
unittests 56.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@freemansw1
Copy link
Member

@w-k-jones happy for you to override and merge; also happy to wait on @JuliaKukulies if she wants to review (or if you want her to review)

@w-k-jones
Copy link
Member Author

Will merge straight away as this doesn't change anything in the tobac package itself

@w-k-jones w-k-jones merged commit b0ca3bc into tobac-project:RC_v1.5.0 Jul 12, 2023
@freemansw1 freemansw1 mentioned this pull request Jul 12, 2023
Closed
@JuliaKukulies
Copy link
Member

Note to @fsenf and me to include this in the dev guide #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freemansw1 freemansw1 freemansw1 approved these changes

@JuliaKukulies JuliaKukulies Awaiting requested review from JuliaKukulies

Assignees

@w-k-jones w-k-jones

Labels
release Organising the next release on conda-forge
Projects
None yet
Milestone
Version 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@w-k-jones @freemansw1 @JuliaKukulies