Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON and Black checks #457

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

freemansw1
Copy link
Member

This addresses #453 and the zenodo JSON checks. Code is touched (due to new black formatting requirements), so want to make this part of 1.5.4.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1
Copy link
Member Author

@JuliaKukulies and @w-k-jones are you happy to review quickly?

Copy link

github-actions bot commented Oct 17, 2024

Linting results by Pylint:

Your code has been rated at 8.74/10 (previous run: 8.74/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.72%. Comparing base (a987435) to head (2ec1642).
Report is 18 commits behind head on RC_v1.5.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.x     #457   +/-   ##
==========================================
  Coverage      60.72%   60.72%           
==========================================
  Files             23       23           
  Lines           3537     3537           
==========================================
  Hits            2148     2148           
  Misses          1389     1389           
Flag Coverage Δ
unittests 60.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freemansw1 freemansw1 added this to the Version 1.5.4 milestone Oct 17, 2024
@freemansw1 freemansw1 added bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review labels Oct 17, 2024
Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this! Happy for this to be merged

@JuliaKukulies
Copy link
Member

Perfect, thanks @freemansw1 !

@freemansw1 freemansw1 merged commit 2b7bb7c into tobac-project:RC_v1.5.x Oct 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants