-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON and Black checks #457
Fix JSON and Black checks #457
Conversation
@JuliaKukulies and @w-k-jones are you happy to review quickly? |
Linting results by Pylint:Your code has been rated at 8.74/10 (previous run: 8.74/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #457 +/- ##
==========================================
Coverage 60.72% 60.72%
==========================================
Files 23 23
Lines 3537 3537
==========================================
Hits 2148 2148
Misses 1389 1389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for solving this! Happy for this to be merged
Perfect, thanks @freemansw1 ! |
This addresses #453 and the zenodo JSON checks. Code is touched (due to new
black
formatting requirements), so want to make this part of 1.5.4.