Skip to content

Commit

Permalink
Merge pull request #10227 from benjaminxscott/1846_bonus_verbiage
Browse files Browse the repository at this point in the history
[1846] use "bonus" terminology
  • Loading branch information
michaeljb authored Feb 3, 2024
2 parents 575c9a3 + ffbdbaa commit 15319b0
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions lib/engine/game/g_1846/game.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class Game < Game::Base
},
],
events: [
{ 'type' => 'remove_markers' },
{ 'type' => 'remove_bonuses' },
{ 'type' => 'remove_reservations' },
],
},
Expand Down Expand Up @@ -201,7 +201,7 @@ class Game < Game::Base

TILE_COST = 20
EVENTS_TEXT = Base::EVENTS_TEXT.merge(
'remove_markers' => ['Remove Markers', 'Remove Steamboat, Meat Packing, and Boomtown markers'],
'remove_bonuses' => ['Remove Bonuses', 'Remove Steamboat, Meat Packing, and Boomtown bonuses'],
'remove_reservations' => ['Remove Reservations', 'Remove reserved token slots for corporations']
).freeze

Expand Down Expand Up @@ -645,11 +645,11 @@ def event_close_companies!
@minors.dup.each { |minor| close_corporation(minor) }
remove_icons(self.class::LSL_HEXES, self.class::ABILITY_ICONS[lake_shore_line.id]) if lake_shore_line
remove_icons(self.class::LITTLE_MIAMI_HEXES, self.class::ABILITY_ICONS[little_miami.id]) if little_miami
remove_steamboat_markers! if steamboat && !steamboat.owned_by_corporation?
remove_steamboat_bonuses! if steamboat && !steamboat.owned_by_corporation?
super
end

def remove_steamboat_markers!
def remove_steamboat_bonuses!
self.class::STEAMBOAT_HEXES.each do |hex_id|
hex = hex_by_id(hex_id)
if hex.assigned?(steamboat.id)
Expand Down Expand Up @@ -678,7 +678,7 @@ def event_remove_reservations!
end
end

def event_remove_markers!
def event_remove_bonuses!
removals = Hash.new { |h, k| h[k] = {} }

@corporations.each do |corp|
Expand All @@ -702,7 +702,7 @@ def event_remove_markers!
removals.each do |company, removal|
hex = removal[:hex]
corp = removal[:corporation]
@log << "-- Event: #{corp}'s #{company_by_id(company).name} marker removed from #{hex} --"
@log << "-- Event: #{corp}'s #{company_by_id(company).name} bonus removed from #{hex} --"
end
end

Expand Down Expand Up @@ -835,7 +835,7 @@ def game_end_check_values
end

def east_west_desc
'E/W'
'East to West'
end

def train_help(_entity, runnable_trains, _routes)
Expand Down
6 changes: 3 additions & 3 deletions lib/engine/game/g_18_los_angeles/game.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Game < G1846::Game
BOOMTOWN_REVENUE_DESC = 'RKO'

EVENTS_TEXT = G1846::Game::EVENTS_TEXT.merge(
'remove_markers' => ['Remove Tokens & Markers', 'Remove RJ token and LA Steamship, LA Citrus, and RKO Pictures markers']
'remove_bonuses' => ['Remove Tokens & Bonuses', 'Remove RJ token and LA Steamship, LA Citrus, and RKO Pictures bonuses']
).freeze

CORPORATION_START_LIMIT = {
Expand Down Expand Up @@ -406,10 +406,10 @@ def east_west_desc
'E/W or N/S'
end

def event_remove_markers!
def event_remove_bonuses!
super

# piggy-back on the markers event to avoid redefining all the trains
# piggy-back on the bonuses event to avoid redefining all the trains
# from 1846 just for the sake of adding a single new event
event_remove_rj_token!
end
Expand Down
2 changes: 1 addition & 1 deletion lib/engine/game/g_18_los_angeles1/game.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Game < G18LosAngeles::Game
LSL_ID = 'SBL'

EVENTS_TEXT = G1846::Game::EVENTS_TEXT.merge(
'remove_markers' => ['Remove Markers', 'Remove LA Steamship and LA Citrus markers']
'remove_bonuses' => ['Remove Bonuses', 'Remove LA Steamship and LA Citrus bonuses']
).freeze

def post_setup; end
Expand Down

0 comments on commit 15319b0

Please sign in to comment.