fix random seed with new seed_v2 db settings field
#10066
Conversation
|
what is used for in game seed?? why is this needed? is seed only used for player order and not game elements? |
* past games have a `seed` that is set when the game is started, that is only used for player order * the new `seed_v2` is used for player order, as well as the in-game `@seed` used by `rand` * new games don't have `seed`, but old games with `seed` and not `seed_v2` will continue to work as before, with `@seed` being set based on the game's ID Fixes tobymao#7465
michaeljb
force-pushed
the
fix-random-seed
branch
from
81671fe to
3774f3d
Compare
|
The original seed is just used for player order, #7465 talks about getting repeatable random elements in the game, for example in 18Chesapeake which corporation's presidents share goes with the Cornelius Vanderbilt company. |
|
Overall looks good. For what its worth...I think its possible to not replace |
|
maybe let’s do that instead? or is player order a new field as well |
|
Player order is an existing field, and I’ve got a script now that I think works for this, I’ll update the PR tomorrow |
|
Changes were significant enough that I made a new branch instead of modifying this one. |
seedthat is set when the game is started, that is only used for player orderseed_v2is used for player order, as well as the in-game@seedused byrandseed, but old games withseedand notseed_v2will continue to work as before, with@seedbeing set based on the game's ID (so no migrations needed)Fixes #7465