[18EU] Leading bidder is removed from auction early

[andrewzwicky]

Before clicking "Create"

• Branch is derived from the latest master
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

• Explanation of Change

  While investigating [18EU] "undefined method `+' for nil" when passing on a minor with no bids #9945 I saw that when a bidder has bid their maximum cash, they are removed from the auction as "can't afford" (because they would not be allowed to bid again). This is not correct in the case where they had bid all their remaining money, and all other players want to pass, as the second place bidder would win the auction. This change leaves them in the auction. If someone else does overbid them, then they are properly removed from the auction.

  I tested the following scenarios:

  • Everyone passes, maxed out bidder wins ✔
  • Someone outbids later, maxed out bidder is removed ✔

  I imported all active 18EU games and validated them, so I don't think this requires pins.

• Screenshots

  Wrong

  Correct

• Any Assumptions / Hacks