suggest Tokaido as a good learning game #10169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminxscott
changed the title
benjaminxscott
changed the title
|
doesn’t seem necessary. i don’t believe beginner variants aren’t particularly useful |
doubt72
reviewed
Jan 23, 2024
| }, | ||
| { | ||
| sym: :limited_express, | ||
| short_name: 'Limited Express 特急', | ||
| desc: '[brutal variant] one less 6 train, 50% to float, 1882-like stock market', | ||
| desc: '[Experienced variant] one fewer 6 train, only 50% to float, 1882-like stock market', |
There was a problem hiding this comment.
I'd quibble. This isn't really an "experienced" variant, it's just brutal. There's a difference.
doubt72
reviewed
Jan 23, 2024
| @@ -100,7 +100,8 @@ def render_content | |||
| h(:a, { attrs: { href: '/login' } }, 'login'), ' to play multiplayer.' | |||
| ] | |||
| end | |||
| description << h(:p, 'If you are new to 18xx games then Shikoku 1889, 18Chesapeake or 18MS are good games to begin with.') | |||
| description << h(:p, 'New? Shikoku 1889 and 18Tokaido have Beginner variants '\ | |||
| 'while 18Chesapeake and 18MS are good learning games') | |||
There was a problem hiding this comment.
This seems to imply 1889 and 18Tokaido are not otherwise good learning games (I think they are). If I'm making this change I'd just list out those four and leave it at that, if there's a beginner variant they can select it (or not).
|
I guess it's not happening anyway, but I had quibbles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweaks some copy to make it more clear which games are good for learning the ropes