Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1846] modify private language copy #10170

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[1846] modify private language copy #10170

merged 1 commit into from
Jan 24, 2024

Conversation

benjaminxscott
Copy link
Contributor

@benjaminxscott benjaminxscott commented Jan 22, 2024

Before clicking "Create"

  • Branch is derived from the latest master
  • [NA] Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

I got a wild hair to rewrite the private descriptions for clarity

The physical game has features where the stock descriptions make sense, but in our digital implementation they are less relevant (e.g. "bonus markers")

I also wanted to address common issues, like
"why doesn't my 2 train run?"
"oops I have to assign the MPC bonus"

  • Screenshots

image

image

  • Any Assumptions / Hacks

@michaeljb michaeljb merged commit 8a51156 into tobymao:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants