Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18SJ] fix setup randomization: shuffle each collection #10206

Merged
merged 1 commit into from
Jan 28, 2024
Merged

[18SJ] fix setup randomization: shuffle each collection #10206

merged 1 commit into from
Jan 28, 2024
+1 −1

Conversation

michaeljb
Copy link
Collaborator

This will require pinning all 18SJ games.

Fixes #10202

@michaeljb michaeljb added the pins PR that will require some games to be pinned label Jan 28, 2024
@michaeljb michaeljb requested a review from perwestling January 28, 2024 04:45
@michaeljb michaeljb changed the title [18SJ] fix setup randommization: shuffle each collection [18SJ] fix setup randomization: shuffle each collection Jan 28, 2024
@michaeljb michaeljb mentioned this pull request Jan 28, 2024
Closed
@michaeljb michaeljb merged commit 0b2d4be into tobymao:master Jan 28, 2024
1 check passed
@michaeljb michaeljb deleted the 18SJ-rand branch January 28, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao approved these changes

@perwestling perwestling Awaiting requested review from perwestling perwestling is a code owner

Assignees
No one assigned
Labels
pins PR that will require some games to be pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[18SJ] rand not called correctly in setup, producing limited combinations of company removals
2 participants
@michaeljb @tobymao