Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18Uruguay] Update Discard train. Only trains shall end up in the bankpool #10213

Closed

Conversation

patrikolesen
Copy link
Contributor

Update Discard train. No ships shall end up in bankpool

Before clicking "Create"

  • Branch is derived from the latest master
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

  • Screenshots

  • Any Assumptions / Hacks

Farms will generate goods once per OR which can be delivered to a near by town of city

The trains can then ship them to a close by port and then RTPLA can ship them to England

This commit covers the delivery both for trains and ships
All corperations will take a loan from RTPLA when floating
It is then optional for the corperation to take one addtional loan per OR
The interest is payed end of OR
It is not possible to repay until Nationalization started

This commit will only add the basic support additional possibilities to take loan and the Nationalization will be handled later
Updating logic in Buy Train to support emergency finance
Adding possibility to take loan before buy train
@patrikolesen
Copy link
Contributor Author

Rebased commit on top of master instead of top of tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant