Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1894] Fix bug stopping company floated in last SR from running trains #10235

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

Galatolol
Copy link
Contributor

  • Branch is derived from the latest master
  • Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

In the last OR set, track and token steps are skipped. If a company floats just before that, it does place its home station but the graph is not recalculated, so for the engine it doesn't have any route.

Technically this requires pinning but it's unlikely to occur... If pinning is problematic, then we can risk not doing it.

@michaeljb michaeljb merged commit 41832dc into tobymao:master Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants