Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1812] multiple pre-alpha updates #11540

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

philcampeau
Copy link
Collaborator

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

  • Sets game to depend on 1867 code
  • add numbers to names of private companies for convenience
  • set minors to 100% float
  • moved PHASES and TRAINS back into base.rb
  • implemented loans, and penalty for not paying interest
  • implemented 2-train export
  • corrected train counts & limits
  • corrected GAME_END_CHECK
  • made p11 and p12 never close

Screenshots

Any Assumptions / Hacks

@philcampeau philcampeau added new games Issues relating to games that are not yet alpha test level 1812 labels Feb 12, 2025
@@ -38,7 +38,7 @@ module Entities
abilities: [], # G-train bonus is defined in game.rb revenue_for method
},
{
name: 'Sheffeild & Rotherham Railway',
name: '4. Sheffeild & Rotherham Railway',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: '4. Sheffeild & Rotherham Railway',
name: '4. Sheffield & Rotherham Railway',

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1812 new games Issues relating to games that are not yet alpha test level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants