fix(tsql): remove BEGIN from identifiers (#4695)

* fix(tsql): remove BEGIN from identifiers * PR feedback 1
tobymao · Feb 3, 2025 · 1904b76 · 1904b76
1 parent 47c0236
commit 1904b76
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/sqlglot/dialects/tsql.py b/sqlglot/dialects/tsql.py
@@ -545,6 +545,13 @@ class Parser(parser.Parser):
             TokenType.OPTION: lambda self: ("options", self._parse_options()),
         }
 
+        # T-SQL does not allow BEGIN to be used as an identifier
+        ID_VAR_TOKENS = parser.Parser.ID_VAR_TOKENS - {TokenType.BEGIN}
+        ALIAS_TOKENS = parser.Parser.ALIAS_TOKENS - {TokenType.BEGIN}
+        TABLE_ALIAS_TOKENS = parser.Parser.TABLE_ALIAS_TOKENS - {TokenType.BEGIN}
+        COMMENT_TABLE_ALIAS_TOKENS = parser.Parser.COMMENT_TABLE_ALIAS_TOKENS - {TokenType.BEGIN}
+        UPDATE_ALIAS_TOKENS = parser.Parser.UPDATE_ALIAS_TOKENS - {TokenType.BEGIN}
+
         FUNCTIONS = {
             **parser.Parser.FUNCTIONS,
             "CHARINDEX": lambda args: exp.StrPosition(

diff --git a/sqlglot/parser.py b/sqlglot/parser.py
@@ -558,8 +558,6 @@ class Parser(metaclass=_Parser):
     }
     ID_VAR_TOKENS.remove(TokenType.UNION)
 
-    INTERVAL_VARS = ID_VAR_TOKENS - {TokenType.END}
-
     TABLE_ALIAS_TOKENS = ID_VAR_TOKENS - {
         TokenType.ANTI,
         TokenType.APPLY,

diff --git a/tests/dialects/test_tsql.py b/tests/dialects/test_tsql.py
@@ -453,6 +453,9 @@ def test_tsql(self):
             },
         )
 
+        with self.assertRaises(ParseError):
+            parse_one("SELECT begin", read="tsql")
+
     def test_option(self):
         possible_options = [
             "HASH GROUP",