Fix(snowflake): ensure OBJECT_CONSTRUCT is not generated inside of VA…

…LUES (#3419)
tobymao · May 7, 2024 · ea197ea · ea197ea
1 parent 17c31da
commit ea197ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/sqlglot/dialects/snowflake.py b/sqlglot/dialects/snowflake.py
@@ -862,7 +862,10 @@ class Generator(generator.Generator):
         }
 
         UNSUPPORTED_VALUES_EXPRESSIONS = {
+            exp.Map,
+            exp.StarMap,
             exp.Struct,
+            exp.VarMap,
         }
 
         def values_sql(self, expression: exp.Values, values_as_table: bool = True) -> str:

diff --git a/tests/dialects/test_snowflake.py b/tests/dialects/test_snowflake.py
@@ -1436,6 +1436,9 @@ def test_minus(self):
         )
 
     def test_values(self):
+        select = exp.select("*").from_("values (map(['a'], [1]))")
+        self.assertEqual(select.sql("snowflake"), "SELECT * FROM (SELECT OBJECT_CONSTRUCT('a', 1))")
+
         self.validate_all(
             'SELECT "c0", "c1" FROM (VALUES (1, 2), (3, 4)) AS "t0"("c0", "c1")',
             read={