add veer_el2_sim board #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wojciech Sipak <[email protected]>
lschuermann
approved these changes
Sep 6, 2024
2 tasks
brghena
reviewed
Sep 20, 2024
Comment on lines
+165
to
+170
| "veer_el2_sim": { | ||
| "description": "VeeR EL2 running on Verilated simulation", | ||
| "arch": "rv32imc", | ||
| "no_attribute_table": True, | ||
| "address_translator": lambda addr: addr - 0x20000000, | ||
| }, |
There was a problem hiding this comment.
I'm definitely not an expert here, but the litex_sim example above this is also a Verilated simulation and has a flash_file parameter. Is that also required here?
There was a problem hiding this comment.
Not necessary, but a good sanity check that ensures we're not creating huge binaries and throwing an error if we would overflow the target's emulated ROM memory region.
bradjc
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using tockloader to create flash files and install applications for VeeR EL2 (see related PR: tock/tock#4118)