JLink: Add serial number argument to specify flashing target #118
Conversation
tyler-potyondy
force-pushed
the
jlink-selector
branch
from
a705ba1 to
a088a79
Compare
tockloader/jlinkexe.py
Outdated
| ).split(), | ||
| ) | ||
| jtag_p = subprocess.Popen( |
There was a problem hiding this comment.
I don't entirely remember why this is here... I made these changes ~6 months ago but forgot to create the PR. I think this may have been an artifact of testing / debugging and shouldn't be here.
tyler-potyondy
force-pushed
the
jlink-selector
branch
3 times, most recently
from
f3c1d87 to
cdd75b4
Compare
|
Alright, should be good to go. @bradjc I think I fixed all the todos. |
| flag. | ||
|
|
||
| tockloader [command] --jlink-serial-number [serial_number] | ||
|
|
There was a problem hiding this comment.
Why is this a separate paragraph?
There was a problem hiding this comment.
I was following the formatting above for this as a code block. Should I alter this?
There was a problem hiding this comment.
No, it's right / necessary for the markdown to render correctly.
Without space before 203:
Without space before 207:
As-is:
There was a problem hiding this comment.
No sorry I meant this is a jlink option (and only jlink) and should go with the --jlink example above.
-adds flag `--jlink-serial-number XXXX` to specify target board
tyler-potyondy
force-pushed
the
jlink-selector
branch
from
cdd75b4 to
604756d
Compare
| @@ -196,6 +199,10 @@ def _run_jtag_commands(self, commands, binary, write=True): | |||
| jlink_file.name, | |||
| ) | |||
|
|
|||
| # Append target selector if serial number provided. | |||
| if self.jlink_serial_number: | |||
| jlink_command += " -USB {}".format(self.jlink_serial_number) | |||
There was a problem hiding this comment.
Eh, I guess this could lead to weird errors if you happen to supply a "serial number" with spaces or other weird characters in there. On the other hand, I don't think we should sanitize these inputs, so this seems good to me.
Overview
Treadmill / CI tests that evaluate networking attach multiple boards to one machine. This PR adds a Tockloader flag (
jlink-serial-no) to specify the JLink serial number of the device that should be flashed.This utilizes JLink's command to specify the serial number of the target.