Update and port to TypeScript #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle "planned" story types * Pass correct id of trello list when creating cards * Correctly create temporary file
* Reformat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, Todd. This isn't so much a standard PR as a full-on rewrite, so feel absolutely free to reject, but I thought I'd at least toss it out there. I needed something like your project for our own team's migration to Trello, but I was having trouble getting your existing codebase working, given all the updates to the Trello and Pivotal API's, and associated libraries, that have happened over the last four years. Even after I updated everything and got things working at a minimal level, it appears that Trello has instituted rate limits on their API's that were blocking the project from running to completion, and with the underlying structure of this project, it was hard to apply the necessary rate limits.
As a result, it seemed easier to switch it over to a
Promises/asyncmodel, and along with that, to convert it to TypeScript.One thing: because it now iterates serially through collections, rather than building and then executing tasks in parallel, it's much slower. Given the Trello rate limits, that's actually a feature and not a bug, but it does mean that it's much slower when importing projects that are small enough to avoid the Trello rate limits.
If you don't want to merge it into your project, that's totally fine - I'll just keep it as a fork.
Let me know what you think.