feat(electron): audio capture permissions and settings #11185

pengx17 · 2025-03-25T12:30:26Z

pengx17 · 2025-03-25T12:30:46Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-03-25T12:38:37Z

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (8c58212) to head (6c125d9).
Report is 2 commits behind head on canary.

Files with missing lines	Patch %	Lines
...end/component/src/ui/lottie/animated-play-icon.tsx	13.33%	13 Missing ⚠️
.../ai/blocks/ai-chat-block/ai-transcription-block.ts	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary   #11185      +/-   ##
==========================================
- Coverage   54.17%   54.10%   -0.07%     
==========================================
  Files        2558     2563       +5     
  Lines      115434   115611     +177     
  Branches    18816    18850      +34     
==========================================
+ Hits        62532    62555      +23     
+ Misses      51571    51086     -485     
- Partials     1331     1970     +639

Flag	Coverage Δ
server-test	`78.66% <ø> (ø)`
unittest	`30.17% <13.63%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

socket-security · 2025-03-28T06:13:47Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	5.12 kB	types

View full report↗︎

packages/frontend/apps/electron/src/main/recording/index.ts

packages/frontend/core/src/modules/media/services/meeting-settings.ts

packages/frontend/apps/electron/src/main/recording/index.ts

packages/frontend/apps/electron/src/main/recording/feature.ts

packages/frontend/core/src/modules/feature-flag/constant.ts

packages/frontend/core/src/modules/media/views/use-seek-time.ts

packages/frontend/core/src/modules/media/webm-encoding.ts

packages/frontend/core/tsconfig.json

packages/frontend/core/src/modules/media/entities/audio-attachment-block.ts

packages/frontend/apps/electron/src/main/recording/index.ts

graphite-app · 2025-03-28T08:07:23Z

Merge activity

Mar 28, 4:07 AM EDT: pengx17 added this pull request to the Graphite merge queue.
Mar 28, 8:36 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
Mar 28, 5:01 AM EDT: pengx17 added this pull request to the Graphite merge queue.
Mar 28, 9:26 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (1)').
Mar 28, 5:35 AM EDT: pengx17 added this pull request to the Graphite merge queue.
Mar 28, 5:36 AM EDT: A user merged this pull request with the Graphite merge queue.

fix AF-2420, AF-2391, AF-2265

This was referenced Mar 25, 2025

feat(electron): recording popups #11016

Merged

feat(editor): audio block #10947

Merged

feat(core): call real endpoint for audio transcription #11139

Merged

github-actions bot added the app:electron Related to electron app label Mar 25, 2025

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from d10b4fd to a1738a7 Compare March 25, 2025 13:53

pengx17 force-pushed the xp/03-24-feat_core_call_real_endpoint_for_audio_transcription branch from f558fb6 to f940d4c Compare March 25, 2025 13:53

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from a1738a7 to 1117818 Compare March 25, 2025 13:57

pengx17 force-pushed the xp/03-24-feat_core_call_real_endpoint_for_audio_transcription branch from f940d4c to 7310469 Compare March 25, 2025 13:57

graphite-app bot force-pushed the xp/03-24-feat_core_call_real_endpoint_for_audio_transcription branch 2 times, most recently from 5ca6439 to e3645bd Compare March 26, 2025 05:09

graphite-app bot force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 1117818 to 42bfe09 Compare March 26, 2025 05:09

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 42bfe09 to a563c99 Compare March 26, 2025 11:00

github-actions bot added mod:i18n Related to i18n mod:component app:core labels Mar 26, 2025

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch 2 times, most recently from 2f6dfc6 to 486d35f Compare March 26, 2025 11:14

github-actions bot added rust mod:native labels Mar 26, 2025

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch 4 times, most recently from 7de30aa to 6f419ca Compare March 27, 2025 05:35

pengx17 force-pushed the xp/03-24-feat_core_call_real_endpoint_for_audio_transcription branch from e3645bd to c6734f9 Compare March 27, 2025 05:35

pengx17 mentioned this pull request Mar 27, 2025

feat(server): update trascript endpoint #11196

Merged

pengx17 force-pushed the xp/03-24-feat_core_call_real_endpoint_for_audio_transcription branch from c6734f9 to e8dcd4e Compare March 27, 2025 08:00

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch 2 times, most recently from 6a87648 to 2687d26 Compare March 27, 2025 08:07

graphite-app bot reviewed Mar 28, 2025

View reviewed changes

packages/frontend/apps/electron/src/main/recording/index.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from a848cdc to 5438c19 Compare March 28, 2025 06:23

graphite-app bot reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/src/modules/media/services/meeting-settings.ts Outdated Show resolved Hide resolved

packages/frontend/apps/electron/src/main/recording/index.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch 2 times, most recently from c2bd229 to 4933fbf Compare March 28, 2025 06:28

Brooooooklyn reviewed Mar 28, 2025

View reviewed changes

packages/frontend/apps/electron/src/main/recording/feature.ts Show resolved Hide resolved

EYHN reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/src/modules/feature-flag/constant.ts Outdated Show resolved Hide resolved

EYHN reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/src/modules/media/views/use-seek-time.ts Outdated Show resolved Hide resolved

EYHN reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/src/modules/media/webm-encoding.ts Outdated Show resolved Hide resolved

EYHN reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/tsconfig.json Outdated Show resolved Hide resolved

EYHN approved these changes Mar 28, 2025

View reviewed changes

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 4933fbf to 01decc9 Compare March 28, 2025 07:19

graphite-app bot changed the base branch from xp/03-24-feat_core_call_real_endpoint_for_audio_transcription to graphite-base/11185 March 28, 2025 07:33

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 01decc9 to 510da5a Compare March 28, 2025 07:33

pengx17 changed the base branch from graphite-base/11185 to xp/03-24-feat_core_call_real_endpoint_for_audio_transcription March 28, 2025 07:33

graphite-app bot requested review from a team March 28, 2025 07:33

graphite-app bot reviewed Mar 28, 2025

View reviewed changes

packages/frontend/core/src/modules/media/entities/audio-attachment-block.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 510da5a to 70d2595 Compare March 28, 2025 07:40

graphite-app bot reviewed Mar 28, 2025

View reviewed changes

packages/frontend/apps/electron/src/main/recording/index.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from 70d2595 to d2645fb Compare March 28, 2025 07:45

graphite-app bot changed the base branch from xp/03-24-feat_core_call_real_endpoint_for_audio_transcription to graphite-base/11185 March 28, 2025 07:59

graphite-app bot changed the base branch from graphite-base/11185 to canary March 28, 2025 08:34

pengx17 force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from d2645fb to cf44970 Compare March 28, 2025 08:40

feat(electron): audio capture permissions and settings (#11185)

6c125d9

fix AF-2420, AF-2391, AF-2265

graphite-app bot force-pushed the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch from cf44970 to 6c125d9 Compare March 28, 2025 09:12

graphite-app bot merged commit 6c125d9 into canary Mar 28, 2025
89 checks passed

graphite-app bot deleted the xp/03-25-feat_electron_audio_capture_permissions_and_settings branch March 28, 2025 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(electron): audio capture permissions and settings #11185

feat(electron): audio capture permissions and settings #11185

pengx17 commented Mar 25, 2025 •

edited

Loading

pengx17 commented Mar 25, 2025 •

edited

Loading

codecov bot commented Mar 25, 2025 •

edited

Loading

socket-security bot commented Mar 28, 2025 •

edited

Loading

graphite-app bot commented Mar 28, 2025 •

edited

Loading

feat(electron): audio capture permissions and settings #11185

feat(electron): audio capture permissions and settings #11185

Conversation

pengx17 commented Mar 25, 2025 • edited Loading

pengx17 commented Mar 25, 2025 • edited Loading

How to use the Graphite Merge Queue

codecov bot commented Mar 25, 2025 • edited Loading

Codecov Report

socket-security bot commented Mar 28, 2025 • edited Loading

graphite-app bot commented Mar 28, 2025 • edited Loading

Merge activity

pengx17 commented Mar 25, 2025 •

edited

Loading

pengx17 commented Mar 25, 2025 •

edited

Loading

codecov bot commented Mar 25, 2025 •

edited

Loading

socket-security bot commented Mar 28, 2025 •

edited

Loading

graphite-app bot commented Mar 28, 2025 •

edited

Loading