Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): update embed iframe toolbar config #11221

Merged

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Mar 27, 2025

part of BS-2843

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review March 27, 2025 01:55
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner March 27, 2025 01:55
@graphite-app graphite-app bot requested review from a team March 27, 2025 01:55
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 54.27%. Comparing base (e763061) to head (0c73fde).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ck-embed/src/embed-iframe-block/configs/toolbar.ts 37.50% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #11221      +/-   ##
==========================================
- Coverage   54.38%   54.27%   -0.12%     
==========================================
  Files        2555     2555              
  Lines      115312   115319       +7     
  Branches    18775    18773       -2     
==========================================
- Hits        62718    62592     -126     
- Misses      50632    50744     +112     
- Partials     1962     1983      +21     
Flag Coverage Δ
server-test 78.90% <ø> (-0.01%) ⬇️
unittest 30.33% <20.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@donteatfriedrice donteatfriedrice force-pushed the 03-26-feat_editor_update_embed_iframe_toolbar_config branch from 32f1c95 to f37251b Compare March 27, 2025 02:28
Copy link

graphite-app bot commented Mar 27, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 03-26-feat_editor_update_embed_iframe_toolbar_config branch from f37251b to 0c73fde Compare March 27, 2025 04:17
@graphite-app graphite-app bot merged commit 0c73fde into canary Mar 27, 2025
79 checks passed
@graphite-app graphite-app bot deleted the 03-26-feat_editor_update_embed_iframe_toolbar_config branch March 27, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants