Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): independent app fallback for mobile #8884

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Nov 21, 2024

No description provided.

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review November 21, 2024 06:43
Copy link
Member Author

EYHN commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a4c749b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (c6ac426) to head (a4c749b).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8884      +/-   ##
==========================================
- Coverage   70.86%   70.25%   -0.62%     
==========================================
  Files         550      550              
  Lines       33980    33980              
  Branches     3089     3052      -37     
==========================================
- Hits        24081    23871     -210     
- Misses       9524     9737     +213     
+ Partials      375      372       -3     
Flag Coverage Δ
server-test 77.14% <ø> (-0.72%) ⬇️
unittest 46.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

graphite-app bot commented Nov 21, 2024

Merge activity

@graphite-app graphite-app bot merged commit a4c749b into canary Nov 21, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/mobile/sp-fallback branch November 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants