Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): mobile sub menu item click handling #8917

Open
wants to merge 1 commit into
base: 11-25-fix_core_should_reset_newpropertyid_state_when_collapsed_change
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 25, 2024

fix AF-1801

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 89cbafe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (cdabc50) to head (89cbafe).

Files with missing lines Patch % Lines
...ges/frontend/component/src/ui/menu/mobile/item.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                                            Coverage Diff                                            @@
##           11-25-fix_core_should_reset_newpropertyid_state_when_collapsed_change    #8917      +/-   ##
=========================================================================================================
+ Coverage                                                                  70.53%   70.58%   +0.04%     
=========================================================================================================
  Files                                                                        544      544              
  Lines                                                                      33741    33743       +2     
  Branches                                                                    3005     3006       +1     
=========================================================================================================
+ Hits                                                                       23799    23817      +18     
+ Misses                                                                      9579     9563      -16     
  Partials                                                                     363      363              
Flag Coverage Δ
server-test 77.14% <ø> (+0.06%) ⬆️
unittest 46.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant