impl crdt types #420
impl crdt types #420
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@forehalo does this crate help? https://docs.rs/crdts/latest/crdts/ |
| }; | ||
| } | ||
|
|
||
| pub enum Value { |
Check warning
Code scanning / clippy
enum `Value` is never used
| @@ -90,6 +100,21 @@ impl StructInfo { | |||
| matches!(self, Self::Item { .. }) | |||
| } | |||
|
|
|||
| pub fn flags(&self) -> ItemFlags { | |||
| match self { | |||
| } | ||
|
|
||
| pub fn insert(&mut self, index: usize, text: String) { | ||
| let pos = self.find_position(index); |
Check warning
Code scanning / clippy
unused variable: `pos`
| self.inner.borrow().len | ||
| } | ||
|
|
||
| pub fn insert(&mut self, index: usize, text: String) { |
Check warning
Code scanning / clippy
unused variable: `text`
| let pos = self.find_position(index); | ||
| } | ||
|
|
||
| fn find_position(&self, index: usize) -> Option<Item> { |
Check warning
Code scanning / clippy
unused variable: `index`
| Ok(()) | ||
| } | ||
|
|
||
| pub fn split_item<I: Into<Id>>(&mut self, id: I, diff: u64) -> JwstCodecResult { |
Check warning
Code scanning / clippy
method `split_item` is never used
|
|
||
| use super::{TypeStore, TypeStoreKind, TypeStoreRef}; | ||
|
|
||
| pub struct YText { |
Check warning
Code scanning / clippy
field `inner` is never read
| use super::{TypeStore, TypeStoreKind, TypeStoreRef}; | ||
|
|
||
| pub struct YText { | ||
| inner: TypeStoreRef, |
Check warning
Code scanning / clippy
field `inner` is never read
| } | ||
|
|
||
| impl YText { | ||
| pub fn len(&self) -> usize { |
Check warning
Code scanning / clippy
method `len` is never used
|
need more discussion |
in these pr, there several things would be done:
will close #405, close #409