Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/scatter-plot-add-selected #144

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

neznayer
Copy link
Contributor

@neznayer neznayer commented Jun 3, 2024

  • 選択の処理を追加
  • API error の表示・非表示

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metastanza-devel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:12am

@neznayer neznayer requested a review from penqe June 3, 2024 09:08
Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他のスタンザに選択イベントを dispatch してる部分が見当たらない気がします。見落としでしたらすみません。

@neznayer
Copy link
Contributor Author

neznayer commented Jun 4, 2024

他のスタンザに選択イベントを dispatch してる部分が見当たらない気がします。見落としでしたらすみません。

レビューありがとうございます!
その部分はここだと思います:
https://github.com/togostanza/metastanza-devel/pull/144/files#diff-07f4fa928662eca2211bf41f66b8326c7a560fbe6ca824bf9883b56369a3bc4bR293-R299

Copy link
Contributor

@penqe penqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@penqe penqe merged commit 0b4a17e into dev Jun 4, 2024
6 checks passed
@penqe penqe deleted the feature/scatter-plot-add-selected branch June 4, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants