Or 1807 fix issues from the internal audit s feedback #255
Conversation
nguyenzung
requested review from
theo-learner,
ohbyeongmin,
steven94kr,
AaronLee22,
0x6e616d and
xxeonge
| @@ -355,8 +403,7 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver { | |||
| // Set the l2Sender so contracts know who triggered this withdrawal on L2. | |||
| l2Sender = _tx.sender; | |||
| if (_tx.value > 0) { | |||
| IERC20(_nativeTokenAddress).safeIncreaseAllowance(_tx.target, _tx.value); | |||
| depositedAmount -= _tx.value; | |||
| IERC20(_nativeTokenAddress).safeIn(_tx.target, _tx.value); | |||
There was a problem hiding this comment.
I think we can fix it! 🙇🏻♂️🙇🏻♂️
There was a problem hiding this comment.
Thank you very much, @rlgns98kr
I updated!
|
Hi @theo-learner |
Ok. Let me check and update it. |
|
@nguyenzung Is it OK to change target branch from codeReview to main? We have to keep the branch permission of codeReview as project FBI's policy. Or I think we can merge it to OR-1810 branch, and then OR-1810 merge to main branch. |
I think it is okay @theo-learner I will make other PR to merge the updated code to the main branch. I make this PR so that we can review the result after internal audit easier arcoding @0x6e616d and @rlgns98kr opinions. I will close this PR after every member verifies the result. Let me think about how to merge to OR-1810. Thank you very much, Theo! |
And I agree your opinion. We can close this PR instead of editing base branch! |
Apply updated code to the codeReview branch
Thank you!