Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update the deploy script #306

Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat: update the deploy script #306

merged 2 commits into from
Dec 5, 2024

Conversation

0x6e616d
Copy link
Member

@0x6e616d 0x6e616d commented Dec 3, 2024

Support deploying the native token on the devnet network

@0x6e616d 0x6e616d requested a review from a team December 3, 2024 12:06
@theo-learner
Copy link
Member

theo-learner commented Dec 4, 2024 •
edited
Loading

Thanks for your working @0x6e616d. Are you checking the failed cases in CI?

theo-learner
theo-learner approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@theo-learner theo-learner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@0x6e616d
Copy link
Member Author

0x6e616d commented Dec 5, 2024

Thanks for your working @0x6e616d. Are you checking the failed cases in CI?

The Contracts test is resolved, I missed to add the new param devent on the Hardhat config file to deploy the L2 native token when testing

@0x6e616d 0x6e616d merged commit 6111afb into main Dec 5, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-learner theo-learner theo-learner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x6e616d @theo-learner